Skip to content
This repository was archived by the owner on May 23, 2022. It is now read-only.

Lg/0.7.2 version#550

Merged
lsgunnlsgunn merged 4 commits intomainfrom
LG/0.7.2-version
Jun 16, 2021
Merged

Lg/0.7.2 version#550
lsgunnlsgunn merged 4 commits intomainfrom
LG/0.7.2-version

Conversation

@lsgunnlsgunn
Copy link
Copy Markdown
Contributor

Overview
I didn't see a lot of interest to external developers to highlight, and the messages were a little cryptic without doing any research. PTAL.

@lsgunnlsgunn lsgunnlsgunn requested a review from a team June 14, 2021 23:02
},
"devDependencies": {
"@dfinity/agent": "0.7.1",
"@dfinity/agent": "0.7.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thing is that the @dfinity/agent version and the dfx version aren't synced anymore, so this may or may not result in the correct output. That being said, if it's just a sample package.json, that's not a big deal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Devs can always get the latest with npm install --save @dfinity/agent

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a sample that gets updated when I do a global version update. But I think this is somewhat hidden information (I think I have it mentioned in the install section because that's where the JS agent was introduced and/or in a previous release note when we decoupled.
I'm thinking of adding this to the text where this example is used:

The version of the JavaScript agent in this example +package.json+ file is +0.7.2+. In most cases, however, you would want to use the latest version of the agent available. When you create a new project, the +dfx new+ command automatically retrieves the latest version of the JavaScript agent for you. You can also manually retrieve the latest version after creating a project by running the +npm install --save @dfinity/agent+ command.


WDYT?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks good to me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. TY. Added here: #553

Comment thread modules/release-notes/pages/0.7.2-rn.adoc Outdated
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
@lsgunnlsgunn lsgunnlsgunn merged commit edb3974 into main Jun 16, 2021
@lsgunnlsgunn lsgunnlsgunn deleted the LG/0.7.2-version branch June 16, 2021 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants